Github user tellison commented on a diff in the pull request:

    https://github.com/apache/incubator-pirk/pull/27#discussion_r72703018
  
    --- Diff: src/main/resources/querier.properties ---
    @@ -0,0 +1,123 @@
    
+###############################################################################
    +# Licensed to the Apache Software Foundation (ASF) under one
    +# or more contributor license agreements.  See the NOTICE file
    +# distributed with this work for additional information
    +# regarding copyright ownership.  The ASF licenses this file
    +# to you under the Apache License, Version 2.0 (the
    +# "License"); you may not use this file except in compliance
    +# with the License.  You may obtain a copy of the License at
    +#
    +#   http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing,
    +# software distributed under the License is distributed on an
    +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +# KIND, either express or implied.  See the License for the
    +# specific language governing permissions and limitations
    +# under the License.
    
+###############################################################################
    +
    +##
    +## Required Properties
    +##
    +
    +#action -- required - 'encrypt' or 'decrypt' -- The action performed by 
the QuerierDriver
    +querier.action=
    +
    +#inputFile - required - Fully qualified file containing input
    +#The input is either:
    +#(1) For Encryption: A query file - Contains the query selectors, one per 
line;
    +#the first line must be the query number
    +#OR
    +#(2) For Decryption: A response file - Contains the serialized Response 
object
    +querier.inputFile=
    +
    +#outputFile -- required - Fully qualified file for the result output.
    +#The output file specifies either:
    +#(1) For encryption:
    +#(a) A file to contain the serialized Querier object named: 
<outputFile>-querier
    +#AND
    +#(b) A file to contain the serialized Query object named: 
<outputFile>-query
    +#OR
    +#(2) A file to contain the decryption results where each line is where 
each line
    +#corresponds to one hit and is a JSON object with the schema QuerySchema
    +querier.outputFile=
    +
    +#numThreads -- required -- Number of threads to use for 
encryption/decryption
    +querier.numThreads=
    --- End diff --
    
    Does this need to be required?  Seems like a sensible default could be 
provided as a convenience.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to