Github user clharris commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/27#discussion_r72730877
--- Diff:
src/main/java/org/apache/pirk/responder/wideskies/spark/ComputeResponse.java ---
@@ -202,7 +203,7 @@ private void setup() throws Exception
numColMultPartitions =
Integer.parseInt(SystemConfiguration.getProperty("pir.numColMultPartitions",
numDataPartsString));
// Whether or not we are performing a reduceByKey or a
groupByKey->reduce for column multiplication
- colMultReduceByKey =
SystemConfiguration.getProperty("pir.colMultReduceByKey").equals("true");
+ colMultReduceByKey =
SystemConfiguration.getProperty("pir.colMultReduceByKey",
"false").equals("true");
--- End diff --
Why is the default for colMultReduceByKey not "true"? Seems opposite what
I'd expect to be optimal.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
