Github user ellisonanne commented on a diff in the pull request:

    https://github.com/apache/incubator-pirk/pull/111#discussion_r84364168
  
    --- Diff: 
src/main/java/org/apache/pirk/querier/wideskies/encrypt/EncryptQuery.java ---
    @@ -178,11 +217,14 @@ public Querier encrypt(int numThreads) throws 
InterruptedException, PIRException
           {
             // Hash collision
             selectorQueryVecMapping.clear();
    -        hashKey = queryInfo.getHashKey() + ++keyCounter;
    +        hashKey = hashKeyBase + getRandByteString(10);
             logger.debug("index = " + index + "selector = " + selector + " 
hash collision = " + hash + " new key = " + hashKey);
             index = -1;
           }
         }
    +    
    +    // Save off the final hashKey that we ended up using
    +    queryInfo.setHashKey(hashKey);
    --- End diff --
    
    Seems reasonable to me - I don't think that we need to allow a user to 
specify a key. If it becomes a requirement down the line, we can always add it 
back as an option.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to