Github user smarthi commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/115#discussion_r85682663
--- Diff: src/main/java/org/apache/pirk/response/wideskies/Response.java ---
@@ -71,4 +71,29 @@ public void addElement(int position, BigInteger element)
{
responseElements.put(position, element);
}
+
+ @Override public boolean equals(Object o)
+ {
+ if (this == o)
+ return true;
+ if (o == null || getClass() != o.getClass())
+ return false;
+
+ Response response = (Response) o;
+
+ if (responseVersion != response.responseVersion)
+ return false;
+ if (!queryInfo.equals(response.queryInfo))
+ return false;
+ return responseElements.equals(response.responseElements);
+
--- End diff --
Can we use Java 8 - Objects.equal() functionality for all equals() methods ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
