Github user wraydulany commented on a diff in the pull request:

    https://github.com/apache/incubator-pirk/pull/115#discussion_r85683430
  
    --- Diff: 
src/test/java/org/apache/pirk/serialization/SerializationTest.java ---
    @@ -75,6 +94,106 @@ public void testJavaSerDe() throws Exception
         Assert.assertTrue(deserializedDummyObject.equals(dummyRecord));
       }
     
    +  @Test
    +  public void testQuerierResponseSerializationDeserialization()
    +  {
    +    testQuerierResponseSerializationDeserialization(jsonSerializer);
    +    testQuerierResponseSerializationDeserialization(javaSerializer);
    --- End diff --
    
    That line isn't in there twice. It's in there once with the arg 
jsonSerializer, and once with the arg javaSerializer. ;) Thus are both extant 
serialization services tested.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to