[ 
https://issues.apache.org/jira/browse/PIVOT-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857562#action_12857562
 ] 

Greg Brown commented on PIVOT-458:
----------------------------------

That is a great point - I hadn't thought about focus traversal in this case. I 
don't think we'd want to split the focus - no other component works that way, 
and I'm not even sure how we would represent it (the focus rect is currently 
drawn around the content).

I'll give it some more thought, but I think that it would probably make sense 
to have the space bar register as a press on the content part of the button 
when "split" is true. The user can still navigate through the items using the 
arrow keys, and we could provide an auxiliary keystroke combination to show the 
popup (e.g. shift-space, or shift-down arrow). We could enable that combination 
even when the button is not split.

The more I think about it, the more I am on the fence about adding this 
behavior to MenuButton as well. MenuButton doesn't currently draw a divider 
between the content and the trigger - if we were to add one, the user wouldn't 
be able to distinguish a menu button from a list button.



> ListButton: show popup only on triangle click
> ---------------------------------------------
>
>                 Key: PIVOT-458
>                 URL: https://issues.apache.org/jira/browse/PIVOT-458
>             Project: Pivot
>          Issue Type: Improvement
>          Components: wtk-terra
>            Reporter: Dirk Moebius
>            Priority: Minor
>         Attachments: listbutton-popup.patch, menubutton-popup.patch
>
>
> I found this to be a requirement in my application: if the user clicks the 
> label part of a LinkButton, the button should fire immediately without 
> showing the popup, thus invoking the action with the currently selected 
> entry. If the user clicks the triangle part, the popup should be shown.
> I patched LinkButton to add a new boolean property called 
> "showPopupOnTriggerClickOnly" to TerraListButtonSkin (I couldn't think of a 
> better name, sorry). If set to true, the ListButton popup will only show up 
> if the user clicks the triangle, but not if the user clicks the rest of the 
> button. However, ButtonPressListeners fire as usual, if the user clicks any 
> part of the button. If the property is false, the behavior is as it was 
> before. The default value of the property is false.
> I tested the patch in my application and ComponentExplorer and it works good.
> It would be nice if you integrate the patch. Otherwise I'd still have the 
> option to write a custom skin, but I think this patch could be interesting to 
> other developers as well.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to