[ 
https://issues.apache.org/jira/browse/PIVOT-383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12871128#action_12871128
 ] 

Sandro Martini commented on PIVOT-383:
--------------------------------------

Hi Greg, 
thanks for the review, and thanks to Martijn for the info (I was writing the 
same things :-) ).

On naming: Yes, pivot-core-1.5-sources.jar  is the right name for the sources 
jar related to pivot-core-1.5.jar
For example, take a look at some artifacts in the main Maven repository , for a 
Martijn-related example here: 
http://repo1.maven.org/maven2/org/apache/wicket/wicket/1.4.9/

So if all it's good I could commit tonight the patch (removing the unnecessary 
dependency from clean, and probably also from trim-whitespace), and closing 
(resolving this issue). In any case, the task is called package-sources, and is 
not called by current build tasks, so anyone who wants those jars generated 
should call it by hand.

For the update to the sh script (outside trunk if I remember well, so outside 
release) I think we can wait Todd, or I can try to make changes by I can't try 
it, so we have to check, Ok ?
Now I'll add a comment for this inside the PIVOT-384 ticket.

Bye,
Sandro


> Jars for Sources in Maven Repository
> ------------------------------------
>
>                 Key: PIVOT-383
>                 URL: https://issues.apache.org/jira/browse/PIVOT-383
>             Project: Pivot
>          Issue Type: Improvement
>    Affects Versions: 1.4
>            Reporter: Sandro Martini
>            Assignee: Sandro Martini
>            Priority: Minor
>             Fix For: 1.5
>
>         Attachments: build.xml.patch, maven-pom-that-builds-pivot.patch
>
>
> In some cases, it's useful to have jars for sources in Maven Repository, so 
> for example from the IDE it's possible to download them and have full 
> navigation support on related sources.
> For a sample of jars to be generated (naming convention etc), take a look 
> here:
> http://repo1.maven.org/maven2/org/apache/tapestry/tapestry-core/5.1.0.5/
> So, we need to modify the build script (only the Maven-related part) to 
> generate the *sources.jar, and maybe also the script to publish them to the 
> maven repository.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to