Hi to all, I've just seen that in TerraTheme, the methods get/set on colors (by index) doesn't have check on the given index, should I add this ?
And then, a little proposal: instead of use a color with: theme.getColor(10) // 10 here means the fourth base color in the palette (zero-based) make it deprecated (optional), and add few new methods to have a cleaner approach (in terms of colors chosen), like: theme.getBaseColor(3) // the fourth base color in the palette (zero-based) but have also variant methods like theme.getDarkerColor(3) // get the darker version of the previous one, without exposing it as index and the same for lighter ... there are already the static darken and lighter methods, but I'd keep them without changes ... or at least no more public, while proposed new methods would be normal (non static). Ok, proposed changes are little, but I think it will be cleaner for us (and for skin implementors) , or better, from my point of view we could make review of skin code in a simpler way, like "the background of any component should use the color X, and their hilite effect should use its variant lighter", and with the proposed syntax maybe could be a little simpler (at least to read in sources) ... And, finally, for the ticket https://issues.apache.org/jira/browse/PIVOT-245 I'm working on, I'm planning to set the current darkening/lightning factor (of +/- 0.1) as an optional value in json colors file (keeping as default the current value), to have a little more control on darkening/lightening on skin colors ... but do you prefer a single value (as today), or maybe two values (one for + , and another for -) ? ... at the moment I think that one could be enough. What do you think ? Sorry, a last thing: trying PanoramaTest (under the tests subproject), to see something on Tooltips, I see that executing the Java class all is good, while executing the related bxml file (panorama_test.bxml), running it as a Pivot Script Application (with the Pivot Eclipse Plugin), I got this, is it right ? java.lang.ClassCastException: org.apache.pivot.wtk.TabPane cannot be cast to org.apache.pivot.wtk.Window at org.apache.pivot.wtk.ScriptApplication.startup(ScriptApplication.java:74) at org.apache.pivot.wtk.DesktopApplicationContext.main(DesktopApplicationContext.java:616) Is it because it doesn't have a full Window defined (and the plugin needs it) ? Thanks to all. Bye, Sandro
