> I've just seen that in TerraTheme, the methods get/set on colors (by > index) doesn't have check on the given index, should I add this ?
Sure. > And then, a little proposal: > instead of use a color with: theme.getColor(10) // 10 here means the > fourth base color in the palette (zero-based) > make it deprecated (optional), and add few new methods to have a > cleaner approach I agree with the intent but I'm not sure it is worth the effort at the moment. At some point we'll hopefully get a "real" designer involved and overhaul the entire theme - until then, I don't think making major changes to Terra is the best use of everyone's time. > And, finally, for the ticket > https://issues.apache.org/jira/browse/PIVOT-245 I'm working on, I'm > planning to set the current darkening/lightning factor (of +/- 0.1) as > an optional value in json colors file (keeping as default the current > value), to have a little more control on darkening/lightening on skin > colors ... but do you prefer a single value (as today), or maybe two > values (one for + , and another for -) ? ... at the moment I think > that one could be enough. I agree that one value is sufficient. > Sorry, a last thing: trying PanoramaTest (under the tests subproject), > to see something on Tooltips, I see that executing the Java class all > is good, while executing the related bxml file (panorama_test.bxml), > running it as a Pivot Script Application (with the Pivot Eclipse > Plugin), I got this, is it right ? > > java.lang.ClassCastException: org.apache.pivot.wtk.TabPane cannot be > cast to org.apache.pivot.wtk.Window > at > org.apache.pivot.wtk.ScriptApplication.startup(ScriptApplication.java:74) > at > org.apache.pivot.wtk.DesktopApplicationContext.main(DesktopApplicationContext.java:616) > > Is it because it doesn't have a full Window defined (and the plugin needs it) > ? Correct - ScriptApplication, which is used by the plugin, requires the root element to be a Window. Trying to launch a BXML file that doesn't contain a Window is analogous to launching a Java class that doesn't contain a main() method.
