Hi to all, some little things found by FindBugs: core/src/org/apache/pivot/beans/BXMLSerializer.java:979 Load of known null value core/src/org/apache/pivot/beans/BXMLSerializer.java:315 Method org.apache.pivot.beans.BXMLSerializer$1.putAll(Map) makes inefficient use of keySet iterator instead of entrySet iterator
wtk/src/org/apache/pivot/wtk/DesktopApplicationContext.java:75 org.apache.pivot.wtk.DesktopApplicationContext$DesktopDisplayHost$1 stored into non-transient field DesktopApplicationContext$DesktopDisplayHost.rootOwnerListener wtk/src/org/apache/pivot/wtk/DesktopApplicationContext.java:147 org.apache.pivot.wtk.DesktopApplicationContext$DesktopDisplayHost$3 stored into non-transient field DesktopApplicationContext$DesktopDisplayHost.updateHostWindowTitleBarCallback wtk/src/org/apache/pivot/wtk/ApplicationContext.java:72 Class org.apache.pivot.wtk.ApplicationContext$DisplayHost defines non-transient non-serializable instance field display wtk/src/org/apache/pivot/wtk/skin/TextAreaSkinParagraphView.java:36 Should org.apache.pivot.wtk.skin.TextAreaSkinParagraphView$Row be a _static_ inner class? wtk/src/org/apache/pivot/wtk/TextArea2.java:42 Should org.apache.pivot.wtk.TextArea2$Paragraph be a _static_ inner class? wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraActivityIndicatorSkin.java:88 Dead store to increment wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraTabPaneSkin.java:1049 Redundant nullcheck of activeTabButton, which is known to be non-null Tell me if I have to fix them, or if someone wants to do it :-) . Bye, Sandro
