>> All of these are because DisplayHost is serializable by inheritance - >> however, no one should be serializing it. You can ignore them. > maybe we can try to make it transient ... and if this doesn't solve I agree > that we can keep it as is.
There's nothing really to solve. DisplayHost shouldn't be serialized. Unfortunately, we can't make it unserializable. But you can make those fields transient if you like. > tutorials/src/org/apache/pivot/tutorials/webqueries/Expenses.java:45 > Write to static field > org.apache.pivot.tutorials.webqueries.Expenses.instance from instance method > new org.apache.pivot.tutorials.webqueries.Expenses() > -- I've seen that the static field is not read, so maybe could be removed > ... It is read - it is returned by getInstance(). > tests/src/org/apache/pivot/tests/sql/ResultListTest.java:40 > org.apache.pivot.tests.sql.ResultListTest.main(String[]) may fail to close > Statement > -- just add a nested try/finally also for the close This has come up before and is a false positive. The "statement" value is only assigned once, and will be closed along with the connection in the existing finally block. > demos-server/src/org/apache/pivot/demos/rest/server/RESTDemoServlet.java:133 > org.apache.pivot.demos.rest.server.RESTDemoServlet.doDelete(QueryServlet$Path) > ignores exceptional return value of java.io.File.delete() > -- just catch also missing exceptions ... I believe this refers to the boolean return value of delete(), not an exception (otherwise, it wouldn't compile). Either way, you can ignore it. It is just a demo application.
