[
https://issues.apache.org/jira/browse/PIVOT-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13003684#comment-13003684
]
Greg Brown commented on PIVOT-708:
----------------------------------
Did you do any tests to determine exactly how much of a performance issue
calling getDateTimeInstance() is? What about tests to verify that making this
change actually improves performance? Note that TerraFileBrowserSkin should
never be called from multiple threads anyway, so the multi-threading issues are
not relevant.
> DateFormat.getDateTimeInstance() is very expensive, we can cache it to
> improve performance
> ------------------------------------------------------------------------------------------
>
> Key: PIVOT-708
> URL: https://issues.apache.org/jira/browse/PIVOT-708
> Project: Pivot
> Issue Type: Improvement
> Components: wtk-terra
> Affects Versions: 2.0
> Reporter: Xiaoming Shi
> Assignee: Sandro Martini
> Priority: Minor
> Fix For: 2.0.1
>
> Attachments: patch.patch
>
>
> In the file
> ./apache-pivot-2.0-src/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraFileBrowserSkin.java
>
> line:281
> DateFormat.getDateTimeInstance() is created in the function. We can cache the
> result by adding a static class field.
> It is similar to the Apache Bug
> https://issues.apache.org/bugzilla/show_bug.cgi?id=48778
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
