[
https://issues.apache.org/jira/browse/PIVOT-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13003689#comment-13003689
]
Sandro Martini commented on PIVOT-708:
--------------------------------------
No, I'm sorry but hadn't time to make some performance tests, but I can say
that one occurrence of this is in the method toString(Object row, String
columnName) , while the other is in render( ... ) and here I expect some
performance improvements.
And I agree with you that there aren't multi-thread issues here, so what do you
think for me to commit this change now, and wait next days for me or others (if
someone finds time ;-) , otherwise me ) to put some timings inside the class,
just to see some number ?
Let me know ...
> DateFormat.getDateTimeInstance() is very expensive, we can cache it to
> improve performance
> ------------------------------------------------------------------------------------------
>
> Key: PIVOT-708
> URL: https://issues.apache.org/jira/browse/PIVOT-708
> Project: Pivot
> Issue Type: Improvement
> Components: wtk-terra
> Affects Versions: 2.0
> Reporter: Xiaoming Shi
> Assignee: Sandro Martini
> Priority: Minor
> Fix For: 2.0.1
>
> Attachments: patch.patch
>
>
> In the file
> ./apache-pivot-2.0-src/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraFileBrowserSkin.java
>
> line:281
> DateFormat.getDateTimeInstance() is created in the function. We can cache the
> result by adding a static class field.
> It is similar to the Apache Bug
> https://issues.apache.org/bugzilla/show_bug.cgi?id=48778
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
