[ 
https://issues.apache.org/jira/browse/PIVOT-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006908#comment-13006908
 ] 

Sandro Martini commented on PIVOT-713:
--------------------------------------

No, at the moment I've only fixed the required class and add method, as 
requested here.
If there are other issues I'm not against removing the final qualifier, but 
probably we should see what real cases are requiring it. But I think it's safe 
to commit this small patch at the moment.

If you think it's useful, I can try to search all "public static final class" 
under the skin and remove the final ... what do you think ?


> Consider making some inner classes non-final
> --------------------------------------------
>
>                 Key: PIVOT-713
>                 URL: https://issues.apache.org/jira/browse/PIVOT-713
>             Project: Pivot
>          Issue Type: Improvement
>          Components: wtk
>    Affects Versions: 2.0
>            Reporter: xiefei
>            Assignee: Sandro Martini
>            Priority: Minor
>             Fix For: 2.0.1
>
>         Attachments: patch.patch
>
>
> I am implementing a groovy-builder-like DSL for pivot using scala. In the 
> DSL, I need subclass of each component/container that retains original 
> component/container behavior but is aware of the DSL context as well. All 
> goes well except GridPane.Row.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to