[
https://issues.apache.org/jira/browse/PIVOT-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008443#comment-13008443
]
Sandro Martini commented on PIVOT-713:
--------------------------------------
Ok, I'll change only those definitions.
But what do you think on this comment by Chris ?
>If GridPane.Row will be made non-final, should it's private 'cells' field also
>be changed to protected or a protected getter added? (And then also for
>TablePane.Row to be consistent?)
So my previous addition even of a protected getCells() method in GridPane and
TablePane.
Tell me if this is needed.
And last:
wtk\src\org\apache\pivot\wtk\GridPane.java
00260: public static class Filler extends Component {
wtk\src\org\apache\pivot\wtk\TablePane.java
00622: public static final class Filler extends Component {
I think it would be better to put GridPane.Filler final, ok ? Tell me.
Bye,
Sandro
> Consider making some inner classes non-final
> --------------------------------------------
>
> Key: PIVOT-713
> URL: https://issues.apache.org/jira/browse/PIVOT-713
> Project: Pivot
> Issue Type: Improvement
> Components: wtk
> Affects Versions: 2.0
> Reporter: xiefei
> Assignee: Sandro Martini
> Priority: Minor
> Fix For: 2.0.1
>
> Attachments: patch.patch,
> patch_remove_final_from_all_public_static_final_class.patch,
> pivot_final_class_grep.txt, pivot_public_static_final_class_grep.txt
>
>
> I am implementing a groovy-builder-like DSL for pivot using scala. In the
> DSL, I need subclass of each component/container that retains original
> component/container behavior but is aware of the DSL context as well. All
> goes well except GridPane.Row.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
