[
https://issues.apache.org/jira/browse/PIVOT-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008445#comment-13008445
]
Greg Brown commented on PIVOT-713:
----------------------------------
No, cells should not have a protected accessor. GridPane.Row implements
Sequence<Component> and wraps the cell list, so its contents are already
accessible. Further, providing a protected accessor would allow subclasses to
circumvent the event processing performed by the base class, which would be bad.
The use case for making these classes non-final is simply to support builders -
it shouldn't be viewed as an excuse to break encapsulation.
> Consider making some inner classes non-final
> --------------------------------------------
>
> Key: PIVOT-713
> URL: https://issues.apache.org/jira/browse/PIVOT-713
> Project: Pivot
> Issue Type: Improvement
> Components: wtk
> Affects Versions: 2.0
> Reporter: xiefei
> Assignee: Sandro Martini
> Priority: Minor
> Fix For: 2.0.1
>
> Attachments: patch.patch,
> patch_remove_final_from_all_public_static_final_class.patch,
> pivot_final_class_grep.txt, pivot_public_static_final_class_grep.txt
>
>
> I am implementing a groovy-builder-like DSL for pivot using scala. In the
> DSL, I need subclass of each component/container that retains original
> component/container behavior but is aware of the DSL context as well. All
> goes well except GridPane.Row.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
