(moved from 'Re: 2.0.1 release')

Roger,

I just had a very quick look at the build.xml file, and it looks like the
'test' ant target only tests the
'core' and 'web' Eclipse projects/subdirectories of trunk.

<!-- Run unit tests -->
<target name="test" description="Executes unit tests" depends="compile">
<test project="core"/>
<test project="web"/>
</target>

However, this seems to be OK, as these are the only 2 Eclipse projects with
'/[project_name]/test' directories (which contain JUnit tests).
This directory structure is the only one that the 'test' macro uses for its
inclusion fileset.
<fileset dir="@{project}/test" includes="**/*Test*.java"/>


As far as I am aware, the 'tests' Eclipse project  (
https://svn.apache.org/repos/asf/pivot/trunk/tests) only contains regular
classes (non-JUnit test cases/suites) located in the '/tests/src' directory.

Their names happen to include 'Test', but they won't be included for testing
as are not in a   '/[project_name]/test' directory of a project specified in
the 'test' ant target.


I'm not stating that 100% of all unit test written for Pivot are run via the
'ant test' command line (as I haven't looked into it before now), but
grepping through the source shouldn't be too painful if we need to check.
 (Just look for JUnit imports?)

Chris

On 23 June 2011 03:17, Roger L. Whitcomb <[email protected]> wrote:

> I think there is another problem -- if you look for *Test*.java, there
> are only two that don't match *Test.java: ListViewTest2.java and
> TableViewTest2.java.  But, if you look at a verbose list of what got run
> by JUnit during "ant test" it only shows the stuff in "test"
> directories, but there are a bunch more in the "tests" directories of
> the "tests" project.  These don't seem to be run anywhere.  How should
> these be run?
>
>
> Roger Whitcomb | Architect, Engineering | [email protected] |
> Ingres | 500 Arguello Street | Suite 200 | Redwood City | CA | 94063 |
> USA  +1 650-587-5596 | fax: +1 650-587-5550
>
> -----Original Message-----
> From: Chris Bartlett [mailto:[email protected]]
> Sent: Wednesday, June 22, 2011 12:29 PM
> To: [email protected]
> Subject: Re: 2.0.1 release
>
> BeanAdapterTestObject is not a JUnit test, but its name matches the
> inclusion criteria.
> <fileset dir="@{project}/test" includes="**/*Test*.java"/>
> So I guess it just needs to be renamed.
>
> XMLSerializerTest *is* a valid test that is failing when checking
> equality
> of Elements.
> Anyone done anything related to this recently?
> (SVN access is slow for me right now, so checking history is painful)
>
> Chris
>
> On 23 June 2011 01:40, Roger L. Whitcomb <[email protected]>
> wrote:
>
> > I ran "ant test" against head revs just now and got two failures:
> >   [junit] Test org.apache.pivot.beans.test.BeanAdapterTestObject
> FAILED
> >   [junit] Test org.apache.pivot.xml.test.XMLSerializerTest FAILED
> >
> > Haven't looked into things further than this.
> >
> > Roger Whitcomb | Architect, Engineering | [email protected] |
> > Ingres | 500 Arguello Street | Suite 200 | Redwood City | CA | 94063 |
> > USA  +1 650-587-5596 | fax: +1 650-587-5550
> >
> > -----Original Message-----
> > From: Chris Bartlett [mailto:[email protected]]
> > Sent: Wednesday, June 22, 2011 11:29 AM
> > To: [email protected]
> > Subject: Re: 2.0.1 release
> >
> > Yep, 6 months is way too long, but with only a few committers whose
> time
> > is
> > limited, it has just ended up that way.
> >
> > Hopefully Piotr's road map question and Greg's friendly push will be
> > enough
> > to kick start the 2.0.1 process..
> >
> > On 23 June 2011 01:20, Edvin Syse <[email protected]> wrote:
> >
> > > I think 6 months is long between each release, but if you release
> > snapshots
> > > atleast each month and update the webpage to show info on the latest
> > > snapshot, you can atleast show that the project is moving forward :)
> > >
> > > Den 22.06.2011 20:04, skrev Chris Bartlett:
> > >
> > >  I'm not sure there would be enough changes to justify official
> > *releases*
> > >> as
> > >> regularly as one per month, but I imagine that regular snapshot
> > builds
> > >> could
> > >> be made available for download.
> > >>
> > >> http://ci.apache.org/
> > >> I will try to read up on what is available to us.
> > >>
> > >> Chris
> > >>
> > >>
> > >> On 23 June 2011 00:16, Greg Brown<[email protected]>  wrote:
> > >>
> > >>  Get the latest source from SVN and build/test the release
> artifacts
> > (run
> > >>> the demos/tutorials/test apps and make sure that nothing is
> broken).
> > Once
> > >>> validated, a release vote can be called for (though a PMC member
> > will
> > >>> need
> > >>> to do that part).
> > >>>
> > >>> Releasing once a month would be aggressive. But if someone is
> > willing to
> > >>> take responsibility for it, I don't see any reason why not.
> > >>>
> > >>> On Jun 22, 2011, at 12:42 PM, Andrei Pozolotin wrote:
> > >>>
> > >>>  what is involved in "get the ball rolling"?
> > >>>>
> > >>>> can you start releasing 2.0.x versions once a month?
> > >>>>
> > >>>> -------- Original Message  --------
> > >>>> Subject: 2.0.1 release
> > >>>> From: Greg Brown<[email protected]>
> > >>>> To: Pivot Dev<[email protected]>
> > >>>> Date: Wed 22 Jun 2011 10:16:40 AM CDT
> > >>>>
> > >>>>> Hi all,
> > >>>>>
> > >>>>> I think the 2.0.1 release is long overdue. Open-source projects
> > without
> > >>>>>
> > >>>> frequent releases seem dead and lose users.
> > >>>
> > >>>>
> > >>>>> I unfortunately cannot drive the process, but I can help
> validate
> > the
> > >>>>>
> > >>>> release if someone is willing to get the ball rolling. Are there
> > any
> > >>> volunteers?
> > >>>
> > >>>>
> > >>>>> Greg
> > >>>>>
> > >>>>>
> > >>>>>
> > >>>>>
> > >>>>
> > >>>
> > >>>
> > >>
> >
>

Reply via email to