Hi all, probably you need to sign an ICLA (for Individuals), or if the code belongs to a Company, a CCLA (for Company), or maybe both ... but add it as a patch in JIRA could be a start (and a good place where to put info, comments, etc). Please remember that our code is based on SVN (not GIT patches, please) ... and verify if generate it from the 2.0.x branch, or if from the trunk.
The code must have a compatible license (maybe Apache :-) ). Then probably we need to add something in NOTICE (if I remember well), change the package, etc ... And of course review dependencies, compatibility of licenses, availability on different platforms, etc ... so not a so small task for us, but for sure this would be a great addition, please have patience to let us handle this one time all the right procedure has started. Thank you very much for now, Sandro 2013/5/28 Roger L. Whitcomb <roger.whitc...@actian.com> > Thank you. Let me take up 2) with ASF legal@ ... I'm not sure how to > handle that. > > > > ~Roger > > > > From: Andrei Pozolotin [mailto:andrei.pozolo...@gmail.com] > Sent: Tuesday, May 28, 2013 11:09 AM > To: Roger L. Whitcomb > Cc: dev@pivot.apache.org; David Ray > Subject: Re: swing and javafx support for pivot > > > > Roger > > 1) yes, we will officially donate code to ASF. > > 2) we would like code/patch/donation to state something to the > effect: > "Developed by David Ray of Barchart, Inc. > http://www.barchart.com" > Where / what is the appropriate way to do this? Example? > > 3) David was planning to create a jira with ASF grant and patch. > > Thank you, > > Andrei > > -------- Original Message -------- > Subject: Re: swing and javafx support for pivot > From: Roger L. Whitcomb <roger.whitc...@actian.com> > <mailto:roger.whitc...@actian.com> > To: Andrei Pozolotin <andrei.pozolo...@gmail.com> > <mailto:andrei.pozolo...@gmail.com> , dev@pivot.apache.org > Cc: "David Ray" <david....@barchart.com> <mailto:david....@barchart.com> > > Date: Tue 28 May 2013 12:38:26 PM CDT > > Hi Andrei, > > I will see if I have some time to take a look at > the patch this week. I think, in general, that this would be a great > idea. I understood from Greg Brown some time ago that this might be > difficult (and indeed I tried it some time ago, and there were > definitely problems). But, if you guys have worked out the bugs, then > that would be tremendous! > > I presume that you and David would be > willing/able to donate the code to the ASF in the event we decide to > accept it?! > > Also, is there an existing JIRA issue you could > update? Or can you create one if not (make it a feature request for 2.1 > version, I presume). > > > > Thank you, > > ~Roger > > > > From: Andrei Pozolotin [mailto:andrei.pozolo...@gmail.com] > Sent: Tuesday, May 28, 2013 10:01 AM > To: dev@pivot.apache.org > Cc: Roger L. Whitcomb; David Ray > Subject: swing and javafx support for pivot > > > > Roger: > > I would like to start a conversation on another topic: > > David Ray produced rather largish patch > which adds swing and javafx support for pivot > > https://github.com/barchart/barchart-pivot/blob/master/pivot-wtk/patch/c > urrent.patch > > Our primary motivation was to get pivot to support java > 7 webkit browser from javafx, > but it does more then that now. > > We would like pivot committers to start reviewing the > patch with the intent to accept it in the trunk. > > What do you think? > > Thank you, > > Andrei > > > >