*Roger*
1) pivot build is ant-centric and treats pom.xml as a byproduct
resource.
2) the "mvn clean install" will not work on the pivot trunk.
3) all you have to do is to add new dependency stanza
|<||dependency||>|
| ||<||groupId||>org.apache.commons</||groupId||>|
| ||<||artifactId||>commons-vfs2</||artifactId||>|
| ||<||version||>2.0</||version||>|
|</||dependency||>|
to pivot-core or whichever module pom.xml template that needs it
so you can communicate the dependency to the maven users.
3) the way to test this is to create a maven project which uses
new pivot build with new dependency and to confirm that it still
builds with "mvn clean install".
4) I tried to convince Greg to mavenize pivot long time back, yet he
was not interested.
as you can see this can be done relatively easy:
https://github.com/barchart/barchart-pivot
but probably needless at this point in time
Thank you,
Andrei
-------- Original Message --------
Subject: Re: New dependency breaks maven build
From: Roger L. Whitcomb <[email protected]>
To: [email protected], Andrei Pozolotin <[email protected]>
Cc: "David Ray" <[email protected]>
Date: Wed 29 May 2013 11:05:33 AM CDT
> So, but I guess I still need help with maven.... I'm not getting "mvn
> install" ever to do anything (substantial, that is), even after "mvn
> clean".... Are we missing something in the "pom.xml" that is currently
> checked into "trunk"?
>
> Thanks,
> ~Roger Whitcomb
>
> -----Original Message-----
> From: Roger L. Whitcomb
> Sent: Wednesday, May 29, 2013 8:51 AM
> To: Andrei Pozolotin
> Cc: [email protected]; David Ray
> Subject: RE: New dependency breaks maven build
>
> Actually, Andrei, the situation was the reverse: "branches/2.0.x" had a
> bug fix that was not in "trunk" yet. But, I have just now done the
> merge and they are back in sync again.
>
>
>
> And, yes, I plan to keep back-porting the fixes as long as feasible.
>
>
> ~Roger Whitcomb
>
>
>
>
> From: Andrei Pozolotin [mailto:[email protected]]
> Sent: Wednesday, May 29, 2013 7:04 AM
> To: Roger L. Whitcomb
> Cc: [email protected]; David Ray
> Subject: Re: New dependency breaks maven build
>
>
>
> I switched our build to branches/2.0.x - works fine - thank you.
>
> please keep back porting pivot fixes from trunk to 2.0.x! :-)
>
> -------- Original Message --------
> Subject: Re: New dependency breaks maven build
> From: Roger L. Whitcomb <[email protected]>
> <mailto:[email protected]>
> To: Andrei Pozolotin <[email protected]>
> <mailto:[email protected]>
> Cc: [email protected], "David Ray" <[email protected]>
> <mailto:[email protected]>
> Date: Tue 28 May 2013 12:38:12 PM CDT
>
> First off, the code in "trunk" I'm working on is not going to be
> ready for release for some time (probably at least a month or two), so I
> would expect changes on an on-going basis. So, absolutely we won't
> release Pivot 2.1 until there is a VFS release that we can use. But, I
> don't really expect to release Pivot 2.1 until close to the end of the
> year, depending on what everybody thinks about the feature set, etc.
>
>
>
> Second, since you're doing (essentially) a private branch, can I
> suggest you branch from the 2.0.x branch instead of "trunk"? As I said
> the code (except for the VFS browser) is identical, so you're not going
> to lose anything wrt your changes. And then you're not going to have
> any problems with unreleased Commons VFS code. We have already started
> some changes to do a 2.0.4 branch, so since you need to build your code
> right now, this would probably be a more stable place to work than
> "trunk" anyway.... And once we iron out the maven stuff in "trunk", you
> could definitely switch at that point. The changes you have made (I
> already took a quick look) are mostly new files and a few changes to
> existing ones, so I don't think it would take much effort to apply the
> patch to "branches/2.0.x" instead of "trunk" anyway.
>
>
>
> Third, there was discussion about the binary incompatibilities
> between VFS 2.0 and 2.1 already. I don't have a reference to the
> discussion right in front of me, but it was their decision, well before
> I had any input.... I could suggest it, but since I'm not a committer
> for Commons my opinion probably wouldn't carry much weight....
>
>
>
> And lastly, could you use the code here:
> http://stackoverflow.com/questions/11450969/apache-commons-vfs-maven-rep
> ository (esp. the <repository> stuff) to enable using the snapshot code
> (if you want to continue using "trunk")?
>
>
>
> ~Roger
>
>
>
> From: Andrei Pozolotin [mailto:[email protected]]
> Sent: Tuesday, May 28, 2013 10:15 AM
> To: Roger L. Whitcomb
> Cc: [email protected]; David Ray
> Subject: Re: New dependency breaks maven build
>
>
>
> maven - no problem, but lets deal with commons-vfs2 dependency
> first
>
> 1) commons-vfs2 v 2.1-SNAPSHOT is binary incompatible with
> release v 2.0
> they changed interfaces, etc. the version really should be 3.X.X
> do you have any say in that? can you make apache commons change
> their mind about version number
> let them read this if they have questions why
> https://github.com/barchart/barchart-version-tester/wiki
>
> https://github.com/barchart/barchart-version-tester/wiki/Version-Policy
>
> 2) I think pivot should depend only on releases.
> can you make apache commons group release commons-vfs2 any time
> soon?
> if not, can we go back to commons-vfs2 v 2.0 release?
>
> issue at hand: we build private version of pivot with maven:
> https://github.com/barchart/barchart-pivot
>
> and maven does not event permit to do a release when you depend
> on snapshot.
> so with current snapshot dependency we are now totally broken
> :-)
>
> -------- Original Message --------
> Subject: Re: New dependency breaks maven build
> From: Roger L. Whitcomb <[email protected]>
> <mailto:[email protected]>
> To: Andrei Pozolotin <[email protected]>
> <mailto:[email protected]> , [email protected]
> Cc: "David Ray" <[email protected]>
> <mailto:[email protected]>
> Date: Tue 28 May 2013 11:58:27 AM CDT
>
> Hi Andrei,
>
> Help with maven would be good. The
> version I am using (and is checked into the "wtk/lib" directory) is a
> pre-release snapshot of 2.1 (version "2.1-SNAPSHOT"). Don't know if
> that will work or not - I'm building Commons locally myself. Attached
> is my attempt at adding the dependency in the "pom.xml", but I'm not
> even getting to first base trying to build with maven myself (i.e., it
> says there is nothing to do even after doing "mvn clean", so I don't get
> the build failures) .... So, any help you could give would be
> appreciated.
>
>
>
> Thanks,
>
> ~Roger Whitcomb
>
>
>
> From: Andrei Pozolotin
> [mailto:[email protected]]
> Sent: Tuesday, May 28, 2013 9:52 AM
> To: [email protected]
> Cc: Roger L. Whitcomb; David Ray
> Subject: Re: New dependency breaks maven build
>
>
>
> Roger:
>
> Thank you for clarification.
>
> Let me know if you need help with maven.
>
> Also, current trunk does not compile with public
> vfs 2.0
>
>
> http://search.maven.org/#artifactdetails%7Corg.apache.commons%7Ccommons-
> vfs2%7C2.0%7Cjar
>
> <dependency>
>
> <groupId>org.apache.commons</groupId>
>
> <artifactId>commons-vfs2</artifactId>
>
> <version>2.0</version>
>
> </dependency>
>
>
> which dependency are you using?
>
> Andrei
>
> -------- Original Message --------
> Subject: Re: New dependency breaks maven build
> From: Roger L. Whitcomb <[email protected]>
> <mailto:[email protected]>
> To: [email protected]
> Cc: "David Ray" <[email protected]>
> <mailto:[email protected]>
> Date: Tue 28 May 2013 11:29:09 AM CDT
>
> My apologies -- I build using Ant, so I didn't
> check the pom.xml. I
> will fix this.
>
> I have added (the beginnings of) two new
> components that duplicate the
> FileBrowser and FileBrowserSheet, but using the
> Commons VFS (Virtual
> File System) so you can browse remote systems,
> inside .zip and .jar
> files, etc. At build time (in the "trunk" code)
> you will need this .jar
> in order to build, and if you use the new
> components you will also need
> the .jar file. But, if you don't use the new
> components you won't need
> the .jar file at runtime.
>
> At the moment, the code in the "branches/2.0.x"
> branch is identical to
> "trunk" (actually better, because it includes a
> bug fix that hasn't been
> migrated to "trunk" yet) (except that "trunk"
> has these new components),
> so if you desperately need to build, I would
> just use this branch
> instead until I get the Maven build working.
>
> HTH,
> ~Roger Whitcomb
>
> -----Original Message-----
> From: Andrei Pozolotin
> [mailto:[email protected]]
> Sent: Tuesday, May 28, 2013 8:46 AM
> To: [email protected]
> Cc: David Ray
> Subject: Re: New dependency breaks maven build
>
> good point. it used here:
>
> http://svn.apache.org/repos/asf/pivot/trunk/core/src/org/apache/pivot/io
> /FileObjectList.java
>
> I am curious if it is really needed?
>
> -------- Original Message --------
> Subject: New dependency breaks maven build
> From: David Ray <[email protected]>
> <mailto:[email protected]>
> To: [email protected]
> Date: Tue 28 May 2013 10:39:35 AM CDT
>
> Hi,
>
> There was a dependency added to
> pivot-core ( org.apache.commons.vfs2 )
>
>
>
> that breaks the maven build I think the
> dependency needs to be added
>
> to the pom.
>
>
> thanks,
> David
>
>
>
>
>
>
>
>
>
>
>
