[ 
https://issues.apache.org/jira/browse/PIVOT-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16427728#comment-16427728
 ] 

Roger Whitcomb commented on PIVOT-1032:
---------------------------------------

Making VFSBrowserSheet as a "final" class may solve some style errors, but 
isn't a good solution for users wanting to subclass, so take it out.

Sending        wtk/src/org/apache/pivot/wtk/VFSBrowserSheet.java
Transmitting file data .done
Committing transaction...
Committed revision 1828486.

> Implement "checkstyle" for builds and make changes to bring code into better 
> compliance
> ---------------------------------------------------------------------------------------
>
>                 Key: PIVOT-1032
>                 URL: https://issues.apache.org/jira/browse/PIVOT-1032
>             Project: Pivot
>          Issue Type: Improvement
>            Reporter: Roger Whitcomb
>            Assignee: Roger Whitcomb
>            Priority: Minor
>         Attachments: 1032.diffs.txt
>
>
> I thought it would be interesting, in addition to the "trim-whitespace" task 
> already implemented, to do some sort of "checkstyle" processing to evaluate 
> all the code to see where there might be changes to make the code more robust 
> and a better example of "canonical" Java style.
> I hesitate to expect that we could address everything (or indeed whether we 
> *should*), but there might be things that would make the code better and 
> easier to read and maintain, and wouldn't take much effort.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to