[
https://issues.apache.org/jira/browse/PIVOT-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16429144#comment-16429144
]
Roger Whitcomb commented on PIVOT-1032:
---------------------------------------
Update the check-style policy to allow 10 parameters to a method; make some
other easy code updates to fix things:
Sending core/src/org/apache/pivot/io/FileList.java
Sending core/src/org/apache/pivot/io/FileObjectList.java
Sending core/src/org/apache/pivot/util/Base64.java
Sending core/test/org/apache/pivot/collections/test/HashMapTest.java
Sending
core/test/org/apache/pivot/serialization/test/ByteArraySerializerTest.java
Sending core/test/org/apache/pivot/util/test/CalendarDateTest.java
Sending demos/src/org/apache/pivot/demos/xml/NodeRenderer.java
Sending pivot_checks.xml
Sending tests/src/org/apache/pivot/tests/HyperlinkButtonTest2.java
Sending tutorials/src/org/apache/pivot/tutorials/effects/Transitions.java
Sending
tutorials/src/org/apache/pivot/tutorials/stocktracker/VolumeMapping.java
Sending wtk/src/org/apache/pivot/wtk/Clipboard.java
Sending wtk/src/org/apache/pivot/wtk/Keyboard.java
Sending wtk/src/org/apache/pivot/wtk/content/ListViewItemRenderer.java
Sending
wtk/src/org/apache/pivot/wtk/content/TableViewImageCellRenderer.java
Sending wtk/src/org/apache/pivot/wtk/content/TreeViewNodeRenderer.java
Sending wtk/src/org/apache/pivot/wtk/skin/ComponentSkin.java
Sending wtk/src/org/apache/pivot/wtk/skin/ContainerSkin.java
Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraGaugeSkin.java
Sending
wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraSliderSkin.java
Transmitting file data ....................done
Committing transaction...
Committed revision 1828576.
> Implement "checkstyle" for builds and make changes to bring code into better
> compliance
> ---------------------------------------------------------------------------------------
>
> Key: PIVOT-1032
> URL: https://issues.apache.org/jira/browse/PIVOT-1032
> Project: Pivot
> Issue Type: Improvement
> Reporter: Roger Whitcomb
> Assignee: Roger Whitcomb
> Priority: Minor
> Attachments: 1032.diffs.txt
>
>
> I thought it would be interesting, in addition to the "trim-whitespace" task
> already implemented, to do some sort of "checkstyle" processing to evaluate
> all the code to see where there might be changes to make the code more robust
> and a better example of "canonical" Java style.
> I hesitate to expect that we could address everything (or indeed whether we
> *should*), but there might be things that would make the code better and
> easier to read and maintain, and wouldn't take much effort.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
