Hi Justin, thanks for finding these … to me both seem absolutely valid the way you did it. I only introduced the named matcher groups recently. Seems I didn’t cleanup the existing code 100% after that ;-)
Chris Am 27.12.17, 07:21 schrieb "Justin Mclean" <[email protected]>: Hi, Just checked in a few unit tests -nothing to existing mostly just for coverage, but I did discover 2 minor issues which I corrected [1][2]. If I’ve done anything wrong please feel free to modify, fix or revert if needed. Thanks, Justin 1. https://github.com/apache/incubator-plc4x/commit/ad6bf6fcbfb7ae9ac35ab09dbaae14e275cc505d 2. https://github.com/apache/incubator-plc4x/commit/a7ab5ee4bd82cdbcb3c2189e376d103d8e5b16cc
