Hi all, as I promised to Sebastian, I just checked the changes in the generification branch.
One thing I did notice, was that one ReadRequest can have different types of items inside … should the ReadRequest / WriteRequest be fixed to one generic type in both cases? Something like this: PlcReadRequest req = new PlcReadRequest(); req.addItem(new ReadRequestItem(Byte.class, inputs)); req.addItem(new ReadRequestItem(Boolean.class, outputs, 3)); CompletableFuture future = plcReader.read(req); PlcReadResponse resp = (PlcReadResponse) future.get(); It does produce warnings, the way it’s currently implemented. Right now, my version allows using all types of items inside one request (even mixed), but we lost generification. Eventually it would be good to have a Read/WriteRequest and a Batch version that’s not generic. What do you think? Right now, I would opt to not merge the changes back until we have discussed this fully. Chris
