As Dale just responded to the test PR I created, having a prefix of “[WIP]” 
(Work in Progress) PRs should not be merged … I think that’s very reasonable :)

Chris

Am 09.01.18, 16:23 schrieb "Christofer Dutz" <[email protected]>:

    Hi all,
    
    I just had Infra turn on Travis support for our Github repo and it 
immediately seems to have worked correctly :-)
    
    So, we should discuss how we want to use Github in general. I know there 
are projects that don’t really use GitHub especially Github PullRequests at all 
and for example in Apache Edgent almost everything is done in Pull Requests. So 
how do we want to do things here?
    
    My opinion would be to utilize whatever the contributor wants. I personally 
prefer to create a feature branch on the ASF Git and have Apache Jenkins auto 
build it. But I think, especially for getting new people on board, Github’s 
workflow is a valuable addition.
    
    So how about this:
    If someone inside the team wants to work on Github, he just does it, 
creates a pull request and merges it himself as soon as he sees the PR being 
fit for merge. If he wants feedback he asks for feedback on the list and 
someone else merges this as soon as the review has been done. If some outside 
user creates a PR, we review within the team it and apply it if we see it fit 
of being merged.
    
    I wouldn’t make things too complicated or restrict ourselves to one set of 
tools. I think we have setup everything to allow all sorts of paths for getting 
code in and having it tested. Allowing all of them keeps the community most 
open to others.
    
    What do you think?
    
    Chris
    
    
    

Reply via email to