Hi Sebatian, having finally finished the VPN tasks I finally had the time for your email.
I think it’s a great idea ... implementing the configuration with apache commons. I definitely have to take a look at this too. So a big +1 from my side. Chris Am 14.05.18, 11:45 schrieb "Sebastian Rühl" <[email protected]>: Hi Together, Im implemented some boundaries on the ADS message parser to prevent parsing of malicious payload: https://github.com/apache/incubator-plc4x/commit/6e3f4a1b55911c553720f26368de69dc056f9774 <https://github.com/apache/incubator-plc4x/commit/6e3f4a1b55911c553720f26368de69dc056f9774> For this im using commons-configuration: https://commons.apache.org/proper/commons-configuration/index.html <https://commons.apache.org/proper/commons-configuration/index.html> Theses properties are as of now only read from system properties globally, but the commons-configiration API allows to easily plug other source in. Here is an example from Netflix which parses from an URL which would be a good fit: https://github.com/OpenEarthDemo/Archaius/blob/master/archaius-core/src/main/java/com/netflix/config/DynamicURLConfiguration.java <https://github.com/OpenEarthDemo/Archaius/blob/master/archaius-core/src/main/java/com/netflix/config/DynamicURLConfiguration.java> I would propose using this consistently over the other protocol implementations. Any opinions on this? Sebastian
