Go for it On Fri., 6 Jul. 2018, 7:43 pm Christofer Dutz, <christofer.d...@c-ware.de> wrote:
> Ok, > > > > I am interpreting the silence as consent and will do the changes I > proposed. > > > > Chris > > > > > > Am 03.07.18, 13:57 schrieb "Christofer Dutz" <christofer.d...@c-ware.de>: > > > > Hi all, > > > > now digging into the subscription features of EtherNet/IP, I also had > a first detailed look at the API for Subscriptions in PLC4X. > > > > I would like to propose refactoring that a little. > > > > I would propose to create SubscriptionRequest and -Response objects > containing SubscriptionItems. > > This way the API would match the Read and Write parts. > > > > Above that it would allow subscribing and unsubscribing to multiple > addresses in one request. > > It would also return a response object that can be used to unsubscribe > again. > > The current solution, passing in the same combination of parameters to > the unsubscription as used when subscribing, is a little fragile in my > opinion. > > > > What do you think? > > > > Chris > > > > >
