chrisdutz commented on a change in pull request #9: Added some javadoc to S7
communication path and several todos that ma…
URL: https://github.com/apache/incubator-plc4x/pull/9#discussion_r207142577
##########
File path:
plc4j/api/src/main/java/org/apache/plc4x/java/api/messages/items/ReadResponseItem.java
##########
@@ -60,6 +66,7 @@ public boolean equals(Object o) {
return false;
}
ReadResponseItem<?> that = (ReadResponseItem<?>) o;
+ // TODO 01.08.18 jf: should we also use a UUID here or at least a
check for equal request as this could lead to effects due to unwanted equality
(same for hashCode).
Review comment:
Generation of UUIDs takes a lot of CPU and consumes Memory
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
