sruehl commented on a change in pull request #23: Added note for Service Loader.
URL: https://github.com/apache/incubator-plc4x/pull/23#discussion_r218678681
 
 

 ##########
 File path: plc4j/api/src/main/java/org/apache/plc4x/java/api/PlcDriver.java
 ##########
 @@ -24,6 +24,10 @@ Licensed to the Apache Software Foundation (ASF) under one
 
 /**
  * General interface defining the minimal methods required for adding a new 
type of driver to the PLC4J system.
+ *
+ * <b>Note that each driver has to add a service file called 
org.apache.plc4x.java.PlcDriver to
+ * src/main/resources/META-INF which contains the fully qualified classname in 
order to get loaded
+ * by the {@link java.sql.DriverManager} instances.</b
 
 Review comment:
   `</b` is missing the closing `>`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to