chrisdutz commented on issue #23: Added note for Service Loader. URL: https://github.com/apache/incubator-plc4x/pull/23#issuecomment-422678186 I would have left the DriverManager (But I do like the name PlcDriverManager more) in the API module, but the problem was that at that time I couldn't write any tests for that as that would have required a cyclic dependency in the maven project graph. I definitely agree that it would be cooler to just depend on the API module. Even if the DriverManager isn't really an API class ... but I guess users would probably forgive us that.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
