sruehl commented on a change in pull request #40: Alias registry for opm
URL: https://github.com/apache/incubator-plc4x/pull/40#discussion_r235883695
##########
File path:
plc4j/protocols/test/src/main/java/org/apache/plc4x/java/mock/PlcMockConnection.java
##########
@@ -39,6 +41,8 @@ Licensed to the Apache Software Foundation (ASF) under one
public class PlcMockConnection implements PlcConnection, PlcReader {
+ private static final Logger logger =
LoggerFactory.getLogger(PlcMockConnection.class);
Review comment:
not sure but sonar might mark this as rule violation because of lowercase
static final. Usually I name them LOGGER for that reason. Not sure if this has
changed meanwhile.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
