JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add Triggering to PLC Scraper URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262821681
########## File path: plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/Scraper.java ########## @@ -19,156 +19,23 @@ package org.apache.plc4x.java.scraper; -import org.apache.commons.collections4.MultiValuedMap; -import org.apache.commons.collections4.multimap.ArrayListValuedHashMap; -import org.apache.commons.lang3.Validate; -import org.apache.commons.lang3.concurrent.BasicThreadFactory; -import org.apache.commons.lang3.tuple.Triple; -import org.apache.commons.math3.stat.descriptive.DescriptiveStatistics; -import org.apache.commons.pool2.impl.GenericKeyedObjectPool; -import org.apache.commons.pool2.impl.GenericKeyedObjectPoolConfig; -import org.apache.plc4x.java.PlcDriverManager; -import org.apache.plc4x.java.api.PlcConnection; -import org.apache.plc4x.java.scraper.config.ScraperConfiguration; -import org.apache.plc4x.java.scraper.util.PercentageAboveThreshold; -import org.apache.plc4x.java.utils.connectionpool.PooledPlcDriverManager; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; - -import java.util.List; -import java.util.Locale; -import java.util.Map; -import java.util.concurrent.*; - /** - * Main class that orchestrates scraping. + * Created by timbo on 2019-03-01 Review comment: We should also keep some (minimal) Jdoc here ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
