+1 (binding) Chris
Here what I checked: - SHA512 Hashes are valid - PGP signatures match - signed by apache email address - zip unpacks - Content of LICENSE, NOTICE, README, RELEASE_NOTES is correct (Except that the LICENSE file contains a list of files, that are not contained in the archive) - README and RELEASE_NOTES matches the files in the archive - Projects builds correctly according to the README - Manually executed RAT: no findings (java -jar ../../../Devtools/Apache/RAT/apache-rat-0.13/apache-rat-0.13.jar -d .) - No SNAPSHOTs referenced - No failed tests (Well ... no tests, so none fail ;-) ) Minor: The Apache License file references files that are not contained in the ZIP Am 26.09.19, 14:10 schrieb "Christofer Dutz" <[email protected]>: Directly when reviewing the RC1 I noticed the RELEASE_NOTES referenced a SNAPSHOT version, so I immediately did a RC2 Apache PLC4X Build-Tools Code-Generation 1.0.0 has been staged under [2] and it’s time to vote on accepting it for release. All Maven artifacts are available under [1]. Voting will be open for 72hr. A minimum of 3 binding +1 votes and more binding +1 than binding -1 are required to pass. Repository: https://gitbox.apache.org/repos/asf/plc4x-build-tools.git Release tag: release/code-generation/1.0.0 Hash for the release tag: 5eb960d1531619d78798fc220aa16fe61cff083f<https://gitbox.apache.org/repos/asf?p=plc4x-build-tools.git;a=commit;h=5eb960d1531619d78798fc220aa16fe61cff083f> Per [3] "Before voting +1 PMC members are required to download the signed source code package, compile it as provided, and test the resulting executable on their own platform, along with also verifying that the package meets the requirements of the ASF policy on releases." You can achieve the above by following [4]. [ ] +1 accept (indicate what you validated - e.g. performed the non-RM items in [4]) [ ] -1 reject (explanation required) [1] https://repository.apache.org/content/repositories/orgapacheplc4x-1011 [2] https://dist.apache.org/repos/dist/dev/plc4x/build-tools/code-generation/1.0.0/rc2/ [3] https://www.apache.org/dev/release.html#approving-a-release [4] https://cwiki.apache.org/confluence/display/PLC4X/Validating+a+staged+Release
