Hi,
+1 (binding)
I checked:
- Signatures and Hashes valid
- signed by apache email
- zip unpacks and has correct structure
- Content of NOTICE, README, RELEASE_NOTES, LICENCE looks good (see below)
- Project builds with procedure described in README (`mvn clean install`) on
macOs Mojave
Minor Issues:
- the mvnw comment in the LICENSE... couldn’t that be in the NOTICE? But I'm
not sure about that and I consider it minor
Good Job Chris!
Julian
Am 27.09.19, 15:37 schrieb "Christofer Dutz" <christofer.d...@c-ware.de>:
+1 (binding)
Chris
Here what I checked:
- SHA512 Hashes are valid
- PGP signatures match
- signed by apache email address
- zip unpacks
- Content of LICENSE, NOTICE, README, RELEASE_NOTES is correct
- README and RELEASE_NOTES matches the files in the archive
- Projects builds correctly according to the README
- Manually executed RAT: no findings (java -jar
../../../Devtools/Apache/RAT/apache-rat-0.13/apache-rat-0.13.jar -d .)
- No SNAPSHOTs referenced
- No failed tests (Well ... no tests, so none fail ;-) )
Am 27.09.19, 15:34 schrieb "Christofer Dutz" <christofer.d...@c-ware.de>:
Apache PLC4X Build-Tools Code-Generation 1.0.0 has been staged under [2]
and it’s time to vote on accepting it for release.
All Maven artifacts are available under [1]. Voting will be open for
72hr.
A minimum of 3 binding +1 votes and more binding +1 than binding -1
are required to pass.
Repository: https://gitbox.apache.org/repos/asf/plc4x-build-tools.git
Release tag: release/code-generation/1.0.0-rc3
Hash for the release tag: af4b5089352a4c785ed6a8ff6f41406a536c3752
Per [3] "Before voting +1 PMC members are required to download
the signed source code package, compile it as provided, and test
the resulting executable on their own platform, along with also
verifying that the package meets the requirements of the ASF policy
on releases."
You can achieve the above by following [4].
[ ] +1 accept (indicate what you validated - e.g. performed the non-RM
items in [4])
[ ] -1 reject (explanation required)
[1]
https://repository.apache.org/content/repositories/orgapacheplc4x-1012<https://repository.apache.org/content/repositories/orgapacheplc4x-10121>
[2]
https://dist.apache.org/repos/dist/dev/plc4x/build-tools/code-generation/1.0.0/rc3/
[3] https://www.apache.org/dev/release.html#approving-a-release
[4]
https://cwiki.apache.org/confluence/display/PLC4X/Validating+a+staged+Release
