+1 (binding) (3 minor issues: Missing profiles in the "build all" part of the README.md, Tests in API modules sometimes fail with Java 13, SNAPSHOT in plc4cpp)
Chris All checks performed: * Checked out using the: OK * Checked signatures: OK * Signed by apache email address: OK * Checked hashes: OK * Checked the zip correctly unpacks to the expected directory structure: OK * README.md and RELEASE_NOTES in the zip are identical to the ones in the release directory: OK * verify the existence of LICENSE, NOTICE, README.md, RELEASE_NOTES: OK * Checked the contents of LICENSE, NOTICE, README.md, RELEASE_NOTES: MINOR (Found some minor things, which I fixed for future releases) * No non-image binaries or unlicensed code (Checked via external RAT: java -Xms1024m -Xmx1024m -jar ../../../../../../../../../../Devtools/Apache/RAT/apache-rat-0.13/apache-rat-0.13.jar . | grep " B "): OK * Built from sources (including tests and all profiles activated) according to instructions in README.md: (MINOR) (With Java 13 I got errors in the plc4j-api tests ... had to downgrade to Java 12, but that worked perfectly) * All tests pass: OK * No usage of SNAPSHOT versions: MINOR (found some SNAPSHOTs in the plc4cpp module, but as this is not usable anyway at the moment and will be moved to the sandbox) Am 24.10.19, 17:28 schrieb "Christofer Dutz" <[email protected]>: Apache PLC4X 0.5.0 has been staged under [2] and it’s time to vote on accepting it for release. All Maven artifacts are available under [1]. Voting will be open for 72hr. A minimum of 3 binding +1 votes and more binding +1 than binding -1 are required to pass. Release tag: release/0.5.0-2 Hash for the release tag: 7293b181d203d915542898932e59bba1a10372b7 Per [3] "Before voting +1 PMC members are required to download the signed source code package, compile it as provided, and test the resulting executable on their own platform, along with also verifying that the package meets the requirements of the ASF policy on releases." You can achieve the above by following [4]. [ ] +1 accept (indicate what you validated - e.g. performed the non-RM items in [4]) [ ] -1 reject (explanation required) [1] https://repository.apache.org/content/repositories/orgapacheplc4x-1016 [2] https://dist.apache.org/repos/dist/dev/plc4x/0.5.0/rc2 [3] https://www.apache.org/dev/release.html#approving-a-release [4] https://cwiki.apache.org/confluence/display/PLC4X/Validating+a+staged+Release
