Hi Alvaro, thanks for bringing that up, its indeed somewhat "new" to get contributions from new community members (too many veterans here). Indeed the next step is waiting for a reviewer. You can write a "Request for Review" mail on the list (the official channel) and also ping people in slack channel.
I hope that someone takes the time today to get the PR through with you (sorry, I was pretty busy the last days). Julian PS.: Gratz to your first PR! : ) Am 16.12.19, 07:17 schrieb "Álvaro Del Castillo" <[email protected]>: Mornign guys, As I am trying to start contributing to PLC4x and I have read the info related to contributing code to the project. The most complete guide is at: https://plc4x.apache.org/developers/contributing.html My first contribution is related to an already open issue: https://issues.apache.org/jira/projects/PLC4X/issues/PLC4X-45 I have created a fork of PLC4x repository, create a branch in my own fork, fix the issue (code+tests) and then, from this branch, I have created the PR: https://github.com/apache/plc4x/pull/109 But right now, I am not sure what the next steps are. Just waiting until some reviewer comment the PR, then I fix any issues, and then the reviewer merge the PR? Should I ask in this mailing list for a reviewer? In slack channel? I have analyzed the last 15 PRs and the average review time is around 4d. Mine is just 4d old, so it is in the normal process. But as a newcomer, I want just to check everything. Cheers and happy week. -- Alvaro
