Hi Justin,

Thanks for the feedback. My last understanding was that it is fine to ship the 
mvn wrapper but it seems that I was wrong.
I will fix that!

Julian

Von meinem Mobiltelefon gesendet


-------- Ursprüngliche Nachricht --------
Von: Justin Mclean <[email protected]>
Datum: Sa., 4. Jan. 2020, 21:58
An: [email protected]
Betreff: Re: [VOTE] Apache PLC4X Build-Tools Code-Generation 1.1.0 RC1
Hi,

-1 (binding) as there is a compiled jar in the source release. [1]

Chris where have I see this same issue before :-)

I checked:
- signatures and hashes are fine
- LICENSE is OK
- NOTICE need year updating
- Unexpected binary fine in the release
- All source  files have ASF headers
- Can compile from source

Thanks,
Justin


1. ./plc4x-code-generaton-1.1.0/.mvn/wrapper/maven-wrapper.jar

Reply via email to