Hi Justin, thanks for your vote and the pointer we indeed missed. I will discuss the issues with Chris who did the implementation and then come back to the list and see how we proceed. It should not be a big issue as we already use Milo since several releases. But I will check in deep!
Julian Am 12.02.20, 02:53 schrieb "Justin Mclean" <[email protected]>: Hi, Sorry but’s it -1 due to license. notice and licensing issues. May need a little discussion to sort out. I checked: - signatures and checksum fine - NOTICE mentions “This product includes software developed at The Milo project (https://github.com/eclipse/milo).” Why is this here? What code is included and how was it licensed? This [8] say it’s EPL which is Category B. - LICENSE is missing mention of these files [1][2][3][4][5][6][7] Where is this code from? - no unexpected binary files - can compile from source Thanks, Justin 1. ./sandbox/test-streampipes-plc4x-processors/src/main/java/org/apache/plc4x/java/streampipes/processors/config/ConfigKeys.java 2. ./sandbox/test-streampipes-plc4x-processors/src/main/java/org/apache/plc4x/java/streampipes/processors/config/Config.java 3. ./sandbox/test-streampipes-plc4x-processors/src/main/java/org/apache/plc4x/java/streampipes/processors/enrich/knxnetip/ets5/Ets5DataEnrichment.java 4. ./sandbox/test-streampipes-plc4x-adapters/src/main/java/org/apache/plc4x/java/streampipes/adapters/config/ConfigKeys.java 5. ./sandbox/test-streampipes-plc4x-adapters/src/main/java/org/apache/plc4x/java/streampipes/adapters/config/ConnectWorkerConfig.java 6. ./sandbox/test-streampipes-plc4x-shared/src/main/java/org/apache/plc4x/java/streampipes/shared/source/bacnetip/Constants.java 7. ./sandbox/test-streampipes-plc4x-shared/src/main/java/org/apache/plc4x/java/streampipes/shared/source/knxnetip/Constants.java 8. https://github.com/eclipse/milo/blob/master/LICENSE.md
