I would hold here for a moment.. If you generate feature file for each and every driver you have then all of them will look like very long list of everything and installation of every next driver might cause reloading of the other one as they share dependencies.
I opt for half hand written and half generated approach. I've made it back in Brussels and redone it recently here: https://github.com/ConnectorIO/connectorio-addons/blob/master/features/plc4x/src/main/feature/feature.xml (sorry for not contributing it back, didn't have time yet) Generated features are fine as long as you do not generate everything, so transports and other things which are shared should be maintained with necessary care. With all love I have for Karaf size of maven sections to get karaf-maven-plugin working are getting sometimes ridiculous size: https://github.com/ConnectorIO/connectorio-addons/blob/addons-2.5.0/features/distributions/siemens/pom.xml#L52L96 not to mention additional dependencies which just pollute maven pom.. Cheers, Łukasz On 11.03.2020 08:22, Christofer Dutz wrote: > Hi all, > > as you know we also produce one driver in a karaf-osgi-bundle-version .. the > s7 driver. > This had a manually written feature.xml which had to be maintained manually. > > I would like to propose to use the karaf-maven-plugin to have this generated > as part of the driver build itself. > > Then the driver build would simply continue to create the driver-jar (nothing > changed here) but also > Produce a feature.xml which would be deployed alongside the jar with a > classifier. > > I think this would simplify things. > > What do you think? > > Chris >
