I vote +1 (non-binding) Niklas
[OK] Download all staged artifacts under the url specified in the release vote email [OK] Verify the signature is correct [OK] Check if the check is successful. [OK] Check if the signature references an Apache email address. [OK] Verify the SHA512 hashes. [OK] Unzip the archive. [OK] Verify the existence of LICENSE, NOTICE, README, RELEASE_NOTES files in the extracted source bundle. [OK] Verify the content of LICENSE, NOTICE, README, RELEASE_NOTES files in the extracted source bundle. [OK] Run RAT [OK] Search for SNAPSHOT [OK] Build the project according to the information in the README.md file. Am 29.03.20 um 19:32 schrieb Lukas Ott: > +1 (binding) > > Lukas > > [OK] Download all staged artifacts under the url specified in the release > vote email into a directory we’ll now call download-dir > [OK] Verify the signature is correct: Additional Apache tutorial on how to > verify downloads can be found here. > [OK] Check if the check is successful. > [OK] Check if the signature references an Apache email address. > [OK] Verify the SHA512 hashes: > [OK] Unzip the archive: > [OK] Verify the existence of LICENSE, NOTICE, README, RELEASE_NOTES files > in the extracted source bundle. > [OK] Verify the content of LICENSE, NOTICE, README, RELEASE_NOTES files in > the extracted source bundle. > (Especially pay attention to the year in the NOTICE file if this is the > first release of the year) > [MINOR] Build the project according to the information in the README.md > file. > [OK] [RM] Build the project with "mvn install" on Ubuntu 19.10 > > Am So., 29. März 2020 um 19:16 Uhr schrieb Christofer Dutz < > christofer.d...@c-ware.de>: > >> +1 (binding) >> >> Chris >> >> [OK] Download all staged artifacts under the url specified in the release >> vote email into a directory we’ll now call download-dir >> [OK] Verify the signature is correct: Additional Apache tutorial on how to >> verify downloads can be found here. >> [OK] Check if the check is successful. >> [OK] Check if the signature references an Apache email address. >> [OK] Verify the SHA512 hashes: >> [OK] Unzip the archive: >> [OK] Verify the existence of LICENSE, NOTICE, README, RELEASE_NOTES files >> in the extracted source bundle. >> [OK] Verify the content of LICENSE, NOTICE, README, RELEASE_NOTES files in >> the extracted source bundle. >> (Especially pay attention to the year in the NOTICE file if this is the >> first release of the year) >> [OK] [RM] Verify the staged source README, RELEASE_NOTE files correspond >> to those in the extracted source bundle. >> [OK] [RM] Run RAT externally to ensure there are no surprises. >> [OK] Search for SNAPSHOT references: >> [MINOR] Build the project according to the information in the README.md >> file. >> [OK] [RM] Build the project with all with-xyz profiles and tests enabled >> and an empty maven local repo: by appendng -Dmaven.repo.local=../.m2. >> >> Notes: >> README: It refers to mvnw but doesn't contain the maven-wrapper >> >> >> Am 29.03.20, 14:59 schrieb "Christofer Dutz" <christofer.d...@c-ware.de>: >> >> Apache PLC4X Build-Tools Code-Generation 1.2.0 has been staged >> under [2] >> and it’s time to vote on accepting it for release. >> >> All Maven artifacts are available under [1]. Voting will be open >> for 72hr. >> >> A minimum of 3 binding +1 votes and more binding +1 than binding -1 >> are required to pass. >> >> Repository: >> https://gitbox.apache.org/repos/asf/plc4x-build-tools.git >> Release tag: release/code-generation/1.2.0 >> Hash for the release tag: plc4x-code-generaton-1.2.0 >> >> Per [3] "Before voting +1 PMC members are required to download >> the signed source code package, compile it as provided, and test >> the resulting executable on their own platform, along with also >> verifying that the package meets the requirements of the ASF policy >> on releases." >> >> You can achieve the above by following [4]. >> >> [ ] +1 accept (indicate what you validated - e.g. performed the >> non-RM items in [4]) >> [ ] -1 reject (explanation required) >> >> >> [1] >> https://repository.apache.org/content/repositories/orgapacheplc4x-1024 >> [2] >> https://dist.apache.org/repos/dist/dev/plc4x/build-tools/code-generation/1.2.0/rc1/ >> [3] >> https://www.apache.org/dev/release/validation.html#approving-a-release >> [4] https://plc4x.apache.org/developers/release/validation.html >> >> >> >> >
