Hi,
my Vote is +1 (binding).
I did.
- Downloaded all artefacts - OK
- Verify Signature - OK
- Verify Hash - OK
- Verify existence and Content fo LICENSE, NOTICE, README, RELEASE_NOTES - OK
- No unexpected binaries - OK
- Build (macOS) - OK
Julian
Am 21.05.20, 11:05 schrieb "Dominik Riemer" <rie...@apache.org>:
Hi,
+1 (non-binding)
I checked:
Download all staged artifacts - OK
Verify the signature is correct - OK
Verify the SHA512 hashes - OK
Verify the existence and content of LICENSE, NOTICE, README, RELEASE_NOTES-
OK
Search for SNAPSHOT references - OK
Build - OK
Some comments:
The RELEASE_NOTES file
(https://dist.apache.org/repos/dist/dev/plc4x/0.7.0/rc2/RELEASE_NOTES) states
"Apache PLC4X 0.7.0-SNAPSHOT" in the first line and for the previous release
0.6.0 the headline is " (Unreleased) Apache PLC4X 0.6.0-SNAPSHOT"
I was using the Docker-based build and had a few minor problems:
- I had to change the base image to use Java 11: FROM azul/zulu-openjdk:11
as build
- I got two compile errors in plc4j-hello-integration-iotdb:
[ERROR] Failed to execute goal
com.offbytwo.maven.plugins:maven-dependency-plugin:3.1.1.MDEP568:go-offline
(default-cli) on project plc4j-hello-integration-iotdb: Failed to resolve
artifact: com.sun.istack:istack-commons-runtime:jar:3.0.6:compile: Could not
find artifact com.sun.istack:istack-commons-runtime:jar:3.0.6 in central
(https://repo.maven.apache.org/maven2) -> [Help 1]
[ERROR] Failed to execute goal
com.offbytwo.maven.plugins:maven-dependency-plugin:3.1.1.MDEP568:go-offline
(default-cli) on project plc4j-hello-integration-iotdb: Failed to resolve
artifact: com.sun.xml.fastinfoset:FastInfoset:jar:1.2.14:compile: Could not
find artifact com.sun.xml.fastinfoset:FastInfoset:jar:1.2.14 in central
(https://repo.maven.apache.org/maven2) -> [Help 1]
I excluded this module to get the build working.
Probably this can be considered minor as it only affects the Docker build.
Dominik
-----Original Message-----
From: Robinet, Etienne <43...@etu.he2b.be>
Sent: Thursday, May 21, 2020 9:23 AM
To: dev@plc4x.apache.org
Subject: Re: [VOTE] Apache PLC4X 0.7.0 RC2
+1
Checklist:
- Download all staged artifacts under the url specified in the release vote
email
- Verify the signature is correct
- Check if the signature references an Apache email address.
- Verify the SHA512 hashes
- Unzip and verify existence and content of LICENSE, NOTICE, README,
RELEASE_NOTES
- Run RAT externally to ensure there are no surprises (also 7 unknown
Licences)
apache-plc4x-0.7.0/build-utils/protocol-base-mspec/src/main/antlr4/org/apache/plc4x/plugins/codegenerator/language/mspec/expression/Expression.g4
apache-plc4x-0.7.0/build-utils/protocol-base-mspec/src/remote-resources/UNLICENSE
apache-plc4x-0.7.0/licenses/UNLICENSE
apache-plc4x-0.7.0/plc4j/examples/hello-webapp/client/asconfig.json
apache-plc4x-0.7.0/plc4j/tools/scraper/src/test/resources/config.json
apache-plc4x-0.7.0/sandbox/code-gen/src/main/resources/example.json
apache-plc4x-0.7.0/sandbox/code-gen/src/main/resources/example2.json
-Search for "SNAPSHOT" and "Copyright" reference
- Build the project according to the information in the README.md
file(./mvnw -P with-sandbox install)
OS: Windows 10 Pro.
Java: OpenJDK 11.02
Maven: 3.6.0
Le mer. 20 mai 2020 à 08:08, Christofer Dutz <christofer.d...@c-ware.de> a
écrit :
> +1 Binding
>
> Chris
>
>
> [OK] Download all staged artifacts under the url specified in the
> release vote email into a directory we’ll now call download-dir.
> [OK] Verify the signature is correct: Additional Apache tutorial on
> how to verify downloads can be found here.
> [OK] Check if the signature references an Apache email address.
> [OK] Verify the SHA512 hashes:
> [OK] Unzip the archive:
> [OK] Verify the existence of LICENSE, NOTICE, README, RELEASE_NOTES
> files in the extracted source bundle.
> [OK] Verify the content of LICENSE, NOTICE, README, RELEASE_NOTES
> files in the extracted source bundle.
> [OK] [RM] Verify the staged source README, RELEASE_NOTE files
> correspond to those in the extracted source bundle.
> [OK] [RM] Run RAT externally to ensure there are no surprises.
> [OK] Search for SNAPSHOT references: Only found in commented out
> dependencies and disabled parts of the project (Parts not yet deleted)
> [OK] Search for Copyright references, and if they are in headers, make
> sure these files containing them are mentioned in the LICENSE file: No
> findings in a bad form, however it seems some files use other apache
> headers as others (Some files have apache headers containing the word
> "copyright" but most don't) [OK] Build the project according to the
> information in the README.md file [OK] [RM] Build the project with all
> with-xyz profiles and tests enabled and an empty maven local repo: by
> appending -Dmaven.repo.local=../.m2.
>
> I did notice a copy+paste error in the vote email ... the nexus repo
> is missing a "-" before the last 4 digits.
>
>
> Am 19.05.20, 23:19 schrieb "Otto Fowler" <ottobackwa...@gmail.com>:
>
> +1 ( FWIW)
>
> Followed the validation steps, built on java 8
>
>
>
> On May 19, 2020 at 15:50:37, Lukas Ott (ott.lukas...@gmail.com) wrote:
>
> +1 (binding)
> Download all staged artifacts - OK
> Verify the signature is correct - OK
> Verify the SHA512 hashes - OK
> Verify the existence and content of LICENSE, NOTICE, README,
> RELEASE_NOTES
> - OK
> Search for SNAPSHOT references - OK
>
> BUILD SUCCESS with: "mvn -P with-sandbox,with-dotnet install"
>
> OS: Ubuntu 20.04 LTS
> Java Version: openjdk version "11.0.7"
> Maven Version: Apache Maven 3.6.3
> dotnet Version: 3.1.202
>
> No additional findings - works for me
>
>
> Am Di., 19. Mai 2020 um 21:01 Uhr schrieb Christofer Dutz <
> christofer.d...@c-ware.de>:
>
> > Apache PLC4X 0.7.0 has been staged under [2] and it’s time to vote
> > on accepting it for release. All Maven artifacts are available
> under [1].
> > Voting will be open for 72hr.
> >
> > A minimum of 3 binding +1 votes and more binding +1 than binding -1
> > are required to pass.
> >
> > Release tag: release/0.7.0
> > Hash for the release tag: a936a9fe1935470f6103f2dcde6d6608d99ddf73
> >
> > Per [3] "Before voting +1 PMC members are required to download
> > the signed source code package, compile it as provided, and test
> > the resulting executable on their own platform, along with also
> > verifying that the package meets the requirements of the ASF policy
> > on releases."
> >
> > You can achieve the above by following [4].
> >
> > [ ] +1 accept (indicate what you validated - e.g. performed the
> non-RM
> > items in [4])
> > [ ] -1 reject (explanation required)
> >
> >
> > [1]
> https://repository.apache.org/content/repositories/orgapacheplc4x1028
> > [2] https://dist.apache.org/repos/dist/dev/plc4x/0.7.0/rc2
> > [3] https://www.apache.org/dev/release.html#approving-a-release
> > [4] https://plc4x.apache.org/developers/release/validation.html
> >
> >
> >
>
>
