Hi,

+1 (non-binding)

[OK] Download all staged artifacts under the url specified in the release vote 
email
[OK] Verify the signature is correct and references an Apache Email address
[OK] Verify the SHA512 hashes
[OK] Unzip the archive
[OK] Verify the existence of LICENSE, NOTICE, README and RELEASE_NOTES files in 
the extracted source bundle.
[OK] Verify the content of LICENSE, NOTICE, README and RELEASE_NOTES files in 
the extracted source bundle.
[OK] Can build from source via "mvn clean install" under Windows 10 (Java 8) 
and W10 WSL2 (Java 11)

Looks good!

Dominik

-----Original Message-----
From: Lukas Ott <[email protected]> 
Sent: Wednesday, September 9, 2020 6:34 PM
To: [email protected]
Subject: Re: [VOTE] Apache PLC4X Build-Tools Code-Generation 1.3.0 RC1

+1 (binding)

[OK] Download all staged artifacts under the url specified in the release vote 
email [OK] Verify the signature is correct and references an Apache Email 
address [OK] Verify the SHA512 hashes [OK] Unzip the archive [OK] Verify the 
existence of LICENSE, NOTICE, README and RELEASE_NOTES files in the extracted 
source bundle.
[OK] Verify the content of LICENSE, NOTICE, README and RELEASE_NOTES files in 
the extracted source bundle.

Can build from Source via "mvn install"
OS: Ubuntu 20.04.1 LTS

No further remarks.

Am Mi., 9. Sept. 2020 um 18:10 Uhr schrieb Christofer Dutz <
[email protected]>:

> +1 (binding)
>
> Chris
>
> [OK] Download all staged artifacts under the url specified in the 
> release vote email [OK] Verify the signature is correct and references 
> an Apache Email address [OK] Verify the SHA512 hashes [OK] Unzip the 
> archive [OK] Verify the existence of LICENSE, NOTICE, README and 
> RELEASE_NOTES files in the extracted source bundle.
> [OK] Verify the content of LICENSE, NOTICE, README and RELEASE_NOTES 
> files in the extracted source bundle.
> [OK] Run RAT externally to ensure there are no surprises.
> [OK] Search for SNAPSHOT references
> [OK] Search for Copyright references, and if they are in headers, make 
> sure these files containing them are mentioned in the LICENSE file.
> [MINOR] Build the project according to the Maven defaults
>
> Remarks:
>
> The script "mvnw" seems to not be executable.
>
>
>
> Am 08.09.20, 13:46 schrieb "Christofer Dutz" <[email protected]>:
>
>        Apache PLC4X Build-Tools Code-Generation 1.3.0 has been staged 
> under [2]
>        and it’s time to vote on accepting it for release.
>
>        All Maven artifacts are available under [1]. Voting will be 
> open for 72hr.
>
>        A minimum of 3 binding +1 votes and more binding +1 than binding -1
>        are required to pass.
>
>        Repository:
> https://gitbox.apache.org/repos/asf/plc4x-build-tools.git
>        Release tag: releases/code-generation/1.3.0
>        Hash for the release tag: 
> 7f2fab83d6cd0ccba41b8622d6abe4f8995748bd
>
>        Per [3] "Before voting +1 PMC members are required to download
>        the signed source code package, compile it as provided, and test
>        the resulting executable on their own platform, along with also
>        verifying that the package meets the requirements of the ASF policy
>        on releases."
>
>        You can achieve the above by following [4].
>
>        [ ]  +1 accept (indicate what you validated - e.g. performed 
> the non-RM items in [4])
>        [ ]  -1 reject (explanation required)
>
>
>     [1]
> https://repository.apache.org/content/repositories/orgapacheplc4x-1029
>     [2]
> https://dist.apache.org/repos/dist/dev/plc4x/build-tools/code-generation/1.3.0/rc1/
>     [3]
> https://www.apache.org/dev/release/validation.html#approving-a-release
>     [4] https://plc4x.apache.org/developers/release/validation.html
>
>
>
>
>

Reply via email to