ottobackwards commented on a change in pull request #214:
URL: https://github.com/apache/plc4x/pull/214#discussion_r546252292
##########
File path:
plc4j/drivers/opcua/src/main/java/org/apache/plc4x/java/opcua/protocol/OpcuaField.java
##########
@@ -68,12 +69,14 @@ public static OpcuaField of(String address) {
String identifier = matcher.group("identifier");
String identifierTypeString = matcher.group("identifierType");
- OpcuaIdentifierType identifierType =
OpcuaIdentifierType.fromString(identifierTypeString);
+ OpcuaIdentifierType identifierType =
OpcuaIdentifierType.enumForValue(identifierTypeString);
Review comment:
What happens if it is an invalid value?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
