ottobackwards commented on pull request #221: URL: https://github.com/apache/plc4x/pull/221#issuecomment-757626947
+1, I think this is correct. Two points though. - It is not good that there are no tests for that, but I don't think that is this PR's responsibility. - This kind of flow if really difficult to grok and troubleshoot. The complete lack of logging here doesn't help things. But again that is beyond this PR's responsibility - ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
