thomas169 opened a new pull request #229: URL: https://github.com/apache/plc4x/pull/229
hello-world-s7 now working when passed connection string with port eg. `s7:tcp://0.0.0.0:102` I don't think it possible that it was working before... ? `spi/src/system.c`: plugged mem leaks, removed unneeded mallocs (ie. mallocs in both `spi/src/system.c` and `spi/src/connection.c`, needed only in 1 of these locations), fixed compiler warnings on `hurz` cast and de-globalized `hurz` (maybe globalness was intended?). Rewrote the connection string parser to use tokenisation rather than walking pointer, which is IMO much clearer. `hello_world_s7.c` beautified some `printf`s and allowed optional cli arguments for setting the test connection string. `transport_tcp.c` fixed compile warning on `printf` without const format specifier. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
