sruehl commented on a change in pull request #230:
URL: https://github.com/apache/plc4x/pull/230#discussion_r596839854
##########
File path:
build-utils/language-java/src/main/java/org/apache/plc4x/language/java/JavaLanguageTemplateHelper.java
##########
@@ -26,13 +26,17 @@ Licensed to the Apache Software Foundation (ASF) under one
import org.apache.plc4x.plugins.codegenerator.types.fields.*;
import org.apache.plc4x.plugins.codegenerator.types.references.*;
import org.apache.plc4x.plugins.codegenerator.types.terms.*;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
import java.util.Map;
import java.util.function.Function;
@SuppressWarnings({"unused", "WeakerAccess"})
public class JavaLanguageTemplateHelper extends
BaseFreemarkerLanguageTemplateHelper {
+ private final Logger logger =
LoggerFactory.getLogger(JavaLanguageTemplateHelper.class);
Review comment:
also it should be static and upper case for sonar 😄
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
