hutcheb commented on pull request #229: URL: https://github.com/apache/plc4x/pull/229#issuecomment-806707519
Yeah that got me at first as well, but I eventually realized that it doesn’t really matter. If you leave anything unintended in a commit you always make another commit to fix it. GitHub has a decent review section in that it will only show the differences between the code at the last commit and the develop branch. If you add code and then remove it won’t show up in the review. If you aren’t completely happy with the status of the PR you can always change it to a draft PR so it doesn’t get merged by accident. But using the same PR will keep all the comments and reviews in the one place. You will also probably need to fill out an agreement with The Apache Foundation (ICLA or CCLA) before something gets merged. I’ll dig up a link that explains it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
