hutcheb commented on a change in pull request #230:
URL: https://github.com/apache/plc4x/pull/230#discussion_r603139882
##########
File path: protocols/ads/src/main/resources/protocols/ads/ads.mspec
##########
@@ -386,7 +386,7 @@
[array int 8 'data' count 'sampleSize']
]
-[dataIo 'DataItem' [string 'dataFormatName', int 32 'stringLength']
+[dataIo 'DataItem' [string '-1' 'dataFormatName', int 32 'stringLength']
Review comment:
'-1' means that it is a null terminated string, which was the default
previously.
We can't have an optional field here using expression as we already have the
encoding field straight after it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
