sruehl commented on a change in pull request #240:
URL: https://github.com/apache/plc4x/pull/240#discussion_r613245819
##########
File path:
build-utils/protocol-base-mspec/src/main/java/org/apache/plc4x/plugins/codegenerator/language/mspec/model/definitions/DefaultComplexTypeDefinition.java
##########
@@ -65,6 +65,11 @@ public boolean isAbstract() {
.collect(Collectors.toList());
}
+ public List<AbstractField> getAbstractFields() {
Review comment:
we should add this method here to
`org.apache.plc4x.plugins.codegenerator.types.definitions.ComplexTypeDefinition`
and add a `Override` annotation
```suggestion
@Override
public List<AbstractField> getAbstractFields() {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
