Hi all,

In PLC4c generated sources s7_var_payload_data_item.c:68 can we change the 
uint8_t itemCount variable to a uint16_t. This becomes a problem when we read 
reasonably big items (256B but still within PDU limits).

I ask as I'm not sure how the generated sources are actually generated. Maybe 
there is some documentation on it?

Thanks,
Thomas

Sent with [ProtonMail](https://protonmail.com) Secure Email.

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Tuesday, 13 April 2021 11:49, Thomas <[email protected]> wrote:

> Hi all,
>
> Re [PR233](https://github.com/apache/plc4x/pull/233). I aim to use PLC4c with 
> digital twins (codegen'd Simulink models) for metal industry and have it talk 
> to Siemens S7 PLCs. Currently use a customized version of libnodave but PLC4x 
> is interesting as it (eventually) works with multiple PLCs & has a C 
> implementation.
>
> In PR233 I have added a loopback test (write values->read them back -> check 
> they match). That's all I need for above use case. To do this I will/did:
>
> - Added write functionality (as in PR) this took a fair bit of time, mostly 
> getting to understand the existing code/datatypes/debugging slowly
> - this morning added error checking to the write responses.
> - I see the read responses are not really checked so I will add this
> - Will check/chase any memory leaks
>
> That's all. After that a few tests in MATLAB/Simulink. If that goes well I 
> can probably help on other protocols in PLC4c.
>
> Cheers,
> Thomas

Reply via email to