splatch commented on pull request #265: URL: https://github.com/apache/plc4x/pull/265#issuecomment-898701955
Hey @rmeister, Thank you for your awesome work. After all looking at amount of code is not that short. :-) If you would wish to test the logic and make sure that it works with certain kind of packets coming from ADS then the best way would be to utilize driver test suite. This is a XML based descriptor of API operations to executed by PLC4X driver, expected messages sent to transport, messages answered by end device as well as messages sent by PLC. Please have a look at canopen sample: https://github.com/apache/plc4x/blob/feature/can-stack-tunning/protocols/canopen/src/test/resources/protocols/canopen/CANOpenDriverSDOIT.xml (note this is in branch, it is intended to be merged into develop) There you can find a test which does several wire operations to confirm that segmentation works fine. Similar thing could be done for ADS driver. Please don't be afraid of lengthily XML. I believe it can be generated with little helper programs pushing data frame into `WriteBufferXmlBased`. Cheers, Łukasz -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
